Step by step
- On the old iPhone, open the vault and run its backup; wait for it to finish.
- Set up the new iPhone (Quick Start or iCloud backup).
- Install the vault app on the new iPhone and restore from its backup.
- Open a few albums to confirm photos and videos are there.
- Only then erase or trade in the old iPhone.
What moves on its own
- Hidden album: with iCloud Photos, it arrives on the new iPhone, still hidden (Apple).
- Locked notes: iCloud notes sync; a custom Notes password works on all devices with your Apple Account (Apple).
- Vault apps: depend on the app's backup. Don't assume a phone-to-phone transfer carries the vault.